Follow-up Comment #2, bug #23334 (project wesnoth): I looked briefly at the MP dependency check module:
https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/depcheck.hpp It looks like it is totally oblivious to add-on versions right now. I think that the intended behavior in 1.12 is most likely that the host should put in game title "requires version X.X.X" and players should always update their add-ons. Not totally sure -- is there another interpretation of the system that makes sense? I made a branch a long time ago to try to make it so that add-ons can be automatically downloaded from the MP lobby. https://github.com/wesnoth/wesnoth/pull/284 This branch does not do version checks right now though, it only would check if you have the add-on at all and prompt to download. I guess that we don't have the ability to do version checks atm. :/ I'm not sure what is needed to make it work right now. --- I think what I would suggest is that, era or modification tags should either (1) Implicitly get the version number from the add-on, from its pbl file, or (2) WML author specifies some version string in [era] or [modification], maybe (1) should be the fallback if (2) does not succeed? maybe scenario tags also should have versions? I think its simpler if there is just one global version number for each add-on but I have not thought much about the possible limitations of this. Then, either in the [era] and [modification] tags, or just in the pbl file, an add-on should specify the smallest number that it is backwards compatible with. So when you don't make a compatibility breaking change, you don't increase the backwards compat version number, and the game (1) won't prompt you to update if you join a game hosting the newer version (2) won't tell another player with a new version that they can't join a game that you host. If you do make a compatibility breaking change, then you do increase the compatibility number, and this will prevent people from interoperating if they have incompatible versions. tekelili do you have any thoughts on this? Especially, do you think its okay for only add-ons to have version numbers or do you think its important that each individual part of the add-on can have a different version number. _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?23334> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Wesnoth-bugs mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-bugs
