-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Rusty Russell a écrit : > Hi all, > > I think it would be useful to automate feedback for tuning campaigns, > particularly wrt. the experience of beginning players. Naturally, we > need to ask permission and collect the minimal relevant information. > > The following patch logs user behaviour: now I have to write the code > (another thread probably) which uploads previous log files to the > server. > > Feedback on C++ (lack-of-) style welcome. >
first, note that obviously, this will not go in 1.1.0 (scheduled for christmas) since we have a pseudo string freeze, and it's a feature that needs some testing ok, I had a good look, and here we go :) 1) you used the wesnoth-lib as gettext domain, I think you should use wesnoth, since it's only in the game, not in the server or editor (Ivanovic probably knows that better than I do) 2) you do quite a couple of include, there is an effort going on to try to simplify the dependancy graph, but I'll let yann tell you more about that (he might be on vacation, though) 3) please use WML instead of a custom output format... we have a good framework to read/write WML, send it over the network etc... we can even compress it, it's all in config.hpp this one is a cshow stopper for me, since we have a good perl library to parse WML and that will simplify report analysis a lot... 4) how does it interact with MP games and replays ? is it logging anything ? in particular the oponents names ? 5) I don't like the idea of a nag screen, even if it's only at first game start, here is a better way to do it have a checkbox option "Log anonymous data" on by default next to it, put two buttons: "clear game logs" and "send logs to developers" this way, the user has to take active (yet simple) steps to send the data, but the data is still stored from the first install, and it's easy to anonymize yourself if you want to... 6) C++ comment... This whole thing just BEGS to become a class :) please answer it's prayer... if you're not familiar with C++, it can be changed afterward Ok, that's all for the moment. Ithink the actual "send the data" part is not the most urgent task right now, pleas handle what I've pointed previously, esp the WML part thx Boucman doing his patch monkey job :) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDpvRJSBeC9Fa95UURApTTAJ9ioLmLJpJNwMZ/0am0ywBCjPHlVACePZfY AsFJIBqWz8ZqqH5LdW858Mw= =30HH -----END PGP SIGNATURE-----
