On Mon, 2005-12-19 at 18:56 +0100, Jérémy Rosen wrote: > Rusty Russell a écrit : > > I think it would be useful to automate feedback for tuning campaigns, > > particularly wrt. the experience of beginning players. Naturally, we > > need to ask permission and collect the minimal relevant information. > > first, note that obviously, this will not go in 1.1.0 (scheduled for > christmas) since we have a pseudo string freeze, and it's a feature that > needs some testing
Definitely. > ok, I had a good look, and here we go :) First up, thanks very much for taking time to give feedback! I'll fix up and send another version. Just a few comments: > 3) please use WML instead of a custom output format... we have a good > framework to read/write WML, send it over the network etc... we can even > compress it, it's all in config.hpp this one is a cshow stopper for me, > since we have a good perl library to parse WML and that will simplify > report analysis a lot... I didn't use WML because (1) I wanted it to be trivially readable (I admit that I failed here) so the user can see what's being sent if they want, and (2) config doesn't seem to guarantee ordering, which makes it a bad match for logging. I'll look at it again though since you feel strongly about it. > 4) how does it interact with MP games and replays ? is it logging > anything ? in particular the oponents names ? It shouldn't do anything in those cases. Will test. > 5) I don't like the idea of a nag screen, even if it's only at first > game start, here is a better way to do it > > have a checkbox option "Log anonymous data" on by default > next to it, put two buttons: "clear game logs" and "send logs to developers" I understand, but I really think the nag screen is required to get statistically valid stats: putting it in the dialog biasses away from beginners (the main area I am trying to address). I have a friend who got to Siege and then gave up on Wesnoth: she simply couldn't get through it. Such information from a newbie who got disheartened is IMHO the most valuable, and a preferences option wouldn't do it 8( > 6) C++ comment... This whole thing just BEGS to become a class :) please > answer it's prayer... if you're not familiar with C++, it can be changed > afterward OK. Originally I didn't know where it would be called from, so it would have had to be a global variable. Since it seems only to be needed in two places, I'll make it a member of something convenient. Thanks! Rusty. -- ccontrol: http://ozlabs.org/~rusty/ccontrol
