Excellent! Thank you very much for doing this. I think that keeping a reasonable level of warnings and then enforcing them strictly will greatly help maintain good code quality.
David Quoting Mark de Wever <[EMAIL PROTECTED]>: > On Sat, Mar 08, 2008 at 05:30:28PM +0100, Mark de Wever wrote: >> Hi, >> >> A few days ago Dave talked with me to make compiler warnings fatal. I >> agreed to make the changes to the build system. Users who don't use >> autotools won't be affected. Obviously there will be a switch to turn >> this option off. >> >> The intention is to make all warnings except the following fatal: >> - signed vs. unsigned comparison >> - unused parameters >> >> I've tested this with gcc-3.3.5 and it works and fixed all remaining >> warnings. Are there more warnings that should be whitelisted? > > I added this to trunk with commit 24502: > Added -Werror -Wno-unused -Wno-sign-compare to the default > compiler flags, can be disabled with --disable-strict-compilation. > > Regards, > Mark de Wever aka Mordante/SkeletonCrew > > _______________________________________________ > Wesnoth-dev mailing list > [email protected] > https://mail.gna.org/listinfo/wesnoth-dev > _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
