On Sun, Jun 29, 2008 at 9:16 PM, Cameron J. Morland <[EMAIL PROTECTED]> wrote:
> On Sun, Jun 29, 2008 at 05:30:47PM +0200, jeremy rosen wrote: > > this sounds like an interesting patch, could you submit it to > > [1]patches.wesnoth.org ? > > Yes, I will as soon as gna.org sends me an email with my account > verification. In the mean time, here's an improved patch. > ok, cool... > > > it's easier for us to deal with it that way... > > > > a few comments while I'm at it so you can work on them right away... > > [snip] > > > 3) please use foreach.hpp instead of a C like "for" loop. You can also > use > > iterators if you want, but avoid the C style as much as possible > > It's not clear to me how to use foreach.hpp, so I used iterators. > just grep for "foreach" in the code, you should have nice examples (though I admit foreach.hpp is not easy to read) of course, iterators are fine, but foreach is such agreat tool, it would be a pity not to know about it > > > 4) hp_dist[hp_dist.size() - 1] = 1 - hp_dist[0]; better written with > > hp_dist.back() > > (I couldn't figure what that line was for, btw, but I did a quick > > review, so i probably missed something) > > It runs in a situation where if I engage in combat and don't die, I > will level up. (e.g. I'm 1 XP short, and fighting a level 1 > creature.) It means "the probability of being fully healed is the > probability of not dying." > ok, I'm still reading the patch without applying nor testing it here, but... this assumes that hp_dist.front is "chances of being unharmed" and hp_dist.back is "chances of dying" is this true even in cases where the unit can't die ? in (theoretical) cases where the unit can't be unharmed ? ok, tell me when the patch is submitted to gna, I'll make sure its commited... > > > On Sun, Jun 29, 2008 at 10:46:47AM -0400, Cameron J. Morland wrote: > > > - sometimes the experience level of the opponent is not correctly > set > > > in opp.u_ > > > > > > - When the defendent can't hit back, both units show as being > > > unharmed. I don't understand why this is. > > I believe I have fixed both of these bugs, which were related. > > -- > +----------------------------------------------------------------- > | PGP > http://www.cns.bu.edu/~cjmorlan/public-key.pgp<http://www.cns.bu.edu/%7Ecjmorlan/public-key.pgp> > | Cameron Morland ---- [EMAIL PROTECTED] > | > | The ink of a scholar is more sacred than the blood of the martyr. > | --Mohammed > +----------------------------------------------------------------- > > _______________________________________________ > Wesnoth-dev mailing list > [email protected] > https://mail.gna.org/listinfo/wesnoth-dev > >
_______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
