On Sun, Jul 01, 2012 at 05:13:11PM +0200, Iurii Chernyi wrote: > On Jun 30, 2012 9:31 PM, "Mark de Wever" <[email protected]> wrote: > > Not really happy to leave style issues when they occur. Is there a > > reason why the main development isn't happening in trunk in the first > > place? > The main development *is* happening in trunk. The merges that I talked > about are potentital merges between upstream trunk code and student's > working copy.
Ok from the original mail I concluded it was developped in another repository. > I agree that it's not good to leave style issues in place. Still, if a > style issue appears in student's code, it's far better to tell him/her > about it, describing the issue, and asking to fix, than to fix it yourself. > The student is here to learn ;) In general I agree, however I tend to fix several pedantic style issues. I don't mind to explain them, but I don't think I should really bother students with it; I also don't bother other developers with it. On the bright side, I haven't had complains from my tests on this code yet. -- Regards, Mark de Wever aka Mordante/SkeletonCrew _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
