It's not my program (obviously), but:

   1.  I'd say that code like "if ( sizeof(number) == 8 )" should have
been a compile-time #ifdef rather than a run-time decision.

   2.  Multiple functions like print_number_as_string() and
print_second_number_as_string() (and so on?) look like a real pain to
use.  The Info-ZIP code uses one function with a ring of string buffers
to ease the load on the programmer.  So long as you don't put too many
calls into the same printf(), it's pretty painless.

   3.  print_second_number_as_string()?  Are you sure the names are long
enough?  (VMS C (by default) truncates externals longer than 31
characters, so I worry about these things even if no one else objects to
typing for days on one statement.)

------------------------------------------------------------------------

   Steven M. Schweda               (+1) 651-699-9818
   382 South Warwick Street        [EMAIL PROTECTED]
   Saint Paul  MN  55105-2547

Reply via email to