Why the need for asprintf() in url.c:903? This function is
missing on DOS/Win32 and nowhere to be found in ./lib.

I suggest we replace with this:

--- hg-latest/src/url.c      Tue Sep 09 12:37:23 2008
+++ url.c       Tue Sep 09 13:01:33 2008
@@ -893,16 +893,18 @@

  if (error_code == PE_UNSUPPORTED_SCHEME)
    {
-      char *error, *p;
+      char *p;
      char *scheme = xstrdup (url);
+      static char error[100];
+
      assert (url_has_scheme (url));

      if ((p = strchr (scheme, ':')))
        *p = '\0';
      if (!strcasecmp (scheme, "https"))
-        asprintf (&error, _("HTTPS support not compiled in"));
+        sprintf (error, _("HTTPS support not compiled in"));
      else
-        asprintf (&error, _(parse_errors[error_code]), quote (scheme));
+        sprintf (error, _(parse_errors[error_code]), quote (scheme));
      xfree (scheme);

      return error;

-------------------

Here 'error' is guaranteed to be big enough.

--gv

Reply via email to