[
https://issues.apache.org/jira/browse/WHIRR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017680#comment-13017680
]
Patrick Hunt commented on WHIRR-275:
------------------------------------
lgtm, a few comments:
1) seems like it would be good to add javadoc for addRule - all the special
cases (for example if source is not specified)
2) javadoc on ports([]) mentioning that the arg replaces, rather than adds, to
the port list.
3) should we considered using guava? Makes collection handling in particular
much easier. then we could standardize around using collections rather than
varargs (could have a single addRule that takes a set say)
> Improve firewall API for services
> ---------------------------------
>
> Key: WHIRR-275
> URL: https://issues.apache.org/jira/browse/WHIRR-275
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Fix For: 0.5.0
>
> Attachments: WHIRR-275.patch, WHIRR-275.patch
>
>
> The API that services use to configure firewall settings is pretty verbose.
> It would be nice to improve it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
