[
https://issues.apache.org/jira/browse/WHIRR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom White updated WHIRR-275:
----------------------------
Attachment: WHIRR-275.patch
Thanks for taking a look Patrick. Here's a new patch that fixes 1) and 2). For
3) I opted to use varargs since it makes it easy to call in the handlers. E.g.
{code}
event.getFirewallManager().addRules(
Rule.create()
.destination(namenode)
.ports(NAMENODE_WEB_UI_PORT, JOBTRACKER_WEB_UI_PORT),
Rule.create()
.source(namenode.getPublicAddress().getHostAddress())
.destination(namenode)
.ports(NAMENODE_PORT, JOBTRACKER_PORT)
);
{code}
We could overload with a method that takes a collection too if needed.
> Improve firewall API for services
> ---------------------------------
>
> Key: WHIRR-275
> URL: https://issues.apache.org/jira/browse/WHIRR-275
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Fix For: 0.5.0
>
> Attachments: WHIRR-275.patch, WHIRR-275.patch, WHIRR-275.patch
>
>
> The API that services use to configure firewall settings is pretty verbose.
> It would be nice to improve it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
