[
https://issues.apache.org/jira/browse/WHIRR-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031275#comment-13031275
]
Adrian Cole commented on WHIRR-61:
----------------------------------
Good start. the following suggestions are mainly just cleanups
I'd probably use MapMaker as it will eliminate the checkNull race condition on
making a new blobstore or computeservice. you can also avoid doing a .copy()
on the ClusterSpec by keying your persistence map on an object summarizing the
unique inputs to createContext. Typically, this is provider, identity,
credential, endpoint (part of properties).
> make more efficient use of ComputeServiceContext
> ------------------------------------------------
>
> Key: WHIRR-61
> URL: https://issues.apache.org/jira/browse/WHIRR-61
> Project: Whirr
> Issue Type: Improvement
> Reporter: Adrian Cole
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-61.patch, WHIRR-61.patch, WHIRR-61.patch
>
>
> The ComputeService object is thread-safe, and better off shared inside the
> Service object. Regardless, it must be closed in order to release
> threadpools.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
