[ 
https://issues.apache.org/jira/browse/WHIRR-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032817#comment-13032817
 ] 

Tom White commented on WHIRR-61:
--------------------------------

> I've fixed a few broken windows (ex. unused imports & fields, missing generic 
> type params, etc) and included these in the same patch intentionally.

Thanks for fixing these, Adrian. In general, developers should run {{mvn 
checkstyle:checkstyle}} and {{mvn apache-rat:check}} before patch submission, 
and committers should do the same before commit.

> make more efficient use of ComputeServiceContext
> ------------------------------------------------
>
>                 Key: WHIRR-61
>                 URL: https://issues.apache.org/jira/browse/WHIRR-61
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Adrian Cole
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-61.patch, WHIRR-61.patch, WHIRR-61.patch, 
> WHIRR-61.patch, WHIRR-61.patch
>
>
> The ComputeService object is thread-safe, and better off shared inside the 
> Service object.  Regardless, it must be closed in order to release 
> threadpools.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to