+1 for making these consistent. Can we deprecate the old settings for at least one release?
Tom On Fri, Jun 24, 2011 at 11:38 AM, Andrei Savu <[email protected]> wrote: > Thanks for the fast reply. I will make the change as discussed. > > Later we should probably put in place a similar convention for tarball > urls. (whirr.<service>.tarball.url) > > Cheers, > > -- Andrei > > On Fri, Jun 24, 2011 at 1:18 PM, Lars George <[email protected]> wrote: >> Hi Andrei, >> >> Tom and I had this discussion a while back, I think one of the issues >> has the notes. I lost momentum since we had no clear consensus, I am >> OK either way as long as it is consistent. >> >> I do favor the "." approach HBase uses. >> >> +1 >> >> Lars >> >> On Fri, Jun 24, 2011 at 12:07 PM, Andrei Savu <[email protected]> wrote: >>> Looks like we a have an naming inconsistency for specifying install / >>> configure functions across services: >>> >>> HBase uses whirr.hbase.(install | configure)-function >>> Hadoop uses whirr.hadoop-(install | configure)-function >>> ZooKeeper uses whirr.zookeeper-(install | configure)-function >>> >>> * Note the . (dot) versus - (dash) after service name >>> >>> I suggest that we should go for: >>> >>> whirr.<service>.(start | stop | install | configure)-function >>> >>> and create a helper function in ClusterActionHandlerSupport for >>> retrieving the value. >>> >>> I will address this in WHIRR-334 [1]. >>> >>> What do you think? >>> >>> [1] https://issues.apache.org/jira/browse/WHIRR-334 >>> >>> -- Andrei Savu / andreisavu.ro >>> >> >
