[
http://issues.apache.org/jira/browse/WICKET-151?page=comments#action_12457031 ]
Eelco Hillenius commented on WICKET-151:
----------------------------------------
Yeah, we should make them final, but that wasn't really the core issue here.
Why my goal was:
public class MyWebSession extends WebSession {
public MyWebSession(Application application) {
setLocale(Locale.US);
}
}
that wouldn't work, as the locale would immediately be overwritten after
creation, while I think fixing the locale like this is a lot more obvious and
elegant then having to override the getLocale method (which is currently the
only way to fix this).
> set session locale when constructing session object
> ---------------------------------------------------
>
> Key: WICKET-151
> URL: http://issues.apache.org/jira/browse/WICKET-151
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 2.0, 1.3
> Reporter: Eelco Hillenius
> Assigned To: Eelco Hillenius
> Fix For: 2.0, 1.3
>
>
> Currently, we create the session objects like this:
> WebApplication#getSession:
> if (session == null)
> {
> // Create session using session factory
> session = getSessionFactory().newSession(request);
> // Set the client Locale for this session
> session.setLocale(request.getLocale());
> What I propose is to change the constructor from Session/ WebSession to take
> in a Locale parameter as well. That would make it possible for custom session
> classes to fix the locale by setting it in the constructor. Now that is only
> possible by overriding Session#getLocale
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
