[ http://issues.apache.org/jira/browse/WICKET-151?page=comments#action_12457037 ] Igor Vaynberg commented on WICKET-151: --------------------------------------
i guess what i am worried about is this the way it is now with getlocale overridible and no setter you can implement the usecase you are describing yourself if you wanted to (given request is a param to the session factory like it already is in 2.0?) but if we create final getter and setter there is no longer a way to pull so we will take flexibility out now i dont know if this particular usecase needs that much flexibility, so maybe taking it out wont hurt anything at this point im +0 > set session locale when constructing session object > --------------------------------------------------- > > Key: WICKET-151 > URL: http://issues.apache.org/jira/browse/WICKET-151 > Project: Wicket > Issue Type: Improvement > Affects Versions: 2.0, 1.3 > Reporter: Eelco Hillenius > Assigned To: Eelco Hillenius > Fix For: 2.0, 1.3 > > > Currently, we create the session objects like this: > WebApplication#getSession: > if (session == null) > { > // Create session using session factory > session = getSessionFactory().newSession(request); > // Set the client Locale for this session > session.setLocale(request.getLocale()); > What I propose is to change the constructor from Session/ WebSession to take > in a Locale parameter as well. That would make it possible for custom session > classes to fix the locale by setting it in the constructor. Now that is only > possible by overriding Session#getLocale -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
