[
https://issues.apache.org/jira/browse/WICKET-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469127
]
Igor Vaynberg commented on WICKET-4:
------------------------------------
yes yes, but can we do it for 2.0? this is a pretty big break in concept. first
we have to remove onbeginrender() then rename any onattach to onbeginrender()
and then create the new onattach(). this means all users have to do the same in
their code! not only that they also need to know to use onbeginrender() instead
of onattach() now.
i dont mind doing it in my 2.0 projects, but what about others?
also we need to lock the hierarachy in onattach(), no point in letting someone
remove a component whose listener is about to get invoked.
> Page.onBeginRequest() [and consequently .onAttach()] not called when form on
> page is submitted.
> -----------------------------------------------------------------------------------------------
>
> Key: WICKET-4
> URL: https://issues.apache.org/jira/browse/WICKET-4
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.2
> Environment: os = OS X 10.4.8; java version = jre/jdk 1.5.0_06;
> servlet container = jetty-5.1.11RC0
> Reporter: Paul Milovanov
> Assigned To: Johan Compagner
> Priority: Critical
> Fix For: 1.3, 2.0
>
>
> Page.onBeginRequest() [and consequently .onAttach()] not called when form on
> page is submitted. Form.onBeginRequest() is not called as well. However,
> Page.onEndRequest() and Form.onEndRequest() are called correctly.
> In more detail:
> I have a page, FrontPage, and a form LoginForm on it (The form has
> defaultFormProcessing = true)
> onBeginRequest(), onEndRequest() in FrontPage, LoginForm, are overriden as
> follows:
> protected void onBeginRequest() {
> log.debug("request begin");
> ...
> super.onBeginRequest();
> }
> protected void onEndRequest() {
> super.onEndRequest();
> ...
> log.debug("request end");
> }
> So I load FrontPage, type in data into the form (that corr. to LoginForm) and
> submit form.
> The log output is as follows
> //first load of page
> DEBUG <hotline.pages.FrontPage> request begin
> ...
> DEBUG <hotline.pages.FrontPage$LoginForm> request begin
> ...
> DEBUG <hotline.pages.FrontPage> request end
> DEBUG <hotline.pages.FrontPage$LoginForm> request end
> ...
> //form submitted
> DEBUG <hotline.pages.FrontPage> request end
> DEBUG <hotline.pages.FrontPage$LoginForm> request end
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
