I like your Idea, but igor is right: putting it into the path makes problems, however, fallback could work in this way:
Indexed-params: 0 = foo 1 = bar non-indexed params: para = morefoo parb = morebar to make URL: mountpoint/foo/bar?para=morefoo&parb=morebar so it wouldnt brake anything and pages still would work, even if there is a param around - and since the param is stored in query, the developer can see it and even fix it if he wants to just my 2 cents... Korbinian > -----Ursprüngliche Nachricht----- > Von: Johan Compagner [mailto:[EMAIL PROTECTED] > Gesendet: Freitag, 27. Oktober 2006 23:31 > An: [email protected] > Betreff: Re: [VOTE] changing the default URL coding strategy > to IndexedParamUrlCodingStrategy / WAS my Feature Request/ > Idea + now proposal (nice URLs) > > hmm dammit.. ;( > > when indexed add a special value ;) > > or register which page (the mount) could be indexed and which > dont then a page can't suddenly has a none index property.. > > But if this is all a case of not being visible. (the > indexedparam..) We could add an extra mount method on application? > > public final void mountIndexedBookmarkablePage(final String > path, final Class bookmarkablePageClass) or public final void > mountBookmarkablePage(final String path, final Class > bookmarkablePageClass, boolean indexed) > > johan > > > > On 10/27/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > > but then you must still somehow know which encoding method > you used :) > > > > /0/value1/1/value2 > > > > is that 0=value1, 1=value2 > > > > or > > > > 0=0,1=value1, 2=1, 3=value2 > > > > -igor > > > > > > On 10/27/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > > > > > > no not an hybrid > > > All the values must be indexed if that is not the case > fall back to > > normal > > > param/value > > > > > > So then when you specify all your params as indexed you > get indexed > > params > > > automatically > > > If you don't param1/value1/1/value2 is generated > > > > > > I dont think hybrid can work. > > > > > > johan > > > > > > > > > On 10/27/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > > > > > > but then you are still encoding the name of the param into the > > > > path > > > > > > > > /param1/value1/0/value2 > > > > > > > > if you dont a hybrid wont work because you wont be able to tell > > > > what > > is > > > > indexed and what is not > > > > > > > > /value1/value2/param1/value3 > > > > > > > > how do you tell 0=value1, 1=value2, param1=value3 ? > > > > > > > > -igor > > > > > > > > > > > > On 10/27/06, Johan Compagner <[EMAIL PROTECTED]> wrote: > > > > > > > > > > i think what we could do is make Indexed a bit > smarter Only let > > > > > its do its job when it really finds parameters that are > > index > > > > (1 > > > > > = > > > > > x, 2 = y) > > > > > If not all params are like that fallback to the > normal name = value. > > > > > > > > > > currently if you make that default i guess this > exception will > > > > > be > > > > thrown: > > > > > > > > > > if (i != parameters.size()) > > > > > { > > > > > throw new WicketRuntimeException( > > > > > "Not all parameters were encoded. > Make sure > > > > > all parameter names are integers in consecutive order > starting > > > > > with > > zero. > > > > > Current parameter names are: " > > > > > + parameters.keySet().toString()); > > > > > } > > > > > > > > > > johan > > > > > > > > > > > > > > > On 10/27/06, Korbinian Bachl <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > as many people need nice URLs in some cases and > these should > > > > > > be > > > > perfect > > > > > to > > > > > > the thing the developer wants, I hereby request to set the > > > > > > default > > > URL > > > > > > codingstrategy for BookmarkablePageLink to > > > > IndexedParamUrlCodingStrategy > > > > > > instead of the current default. > > > > > > > > > > > > For the exact Reasons and more infos, please see the Thread > > > > > > "my > > > > Feature > > > > > > Request/ Idea + now proposal (nice URLs)" on this > mailinglist. > > > > > > > > > > > > [-1] No! - The current default (/paramname/paramvalue) is > > > > > > better > > > IMHO > > > > > > [ 0] I don't care > > > > > > [+1] YES ! - I prefer /value1/value2 and dont want more URL > > > > discussions! > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > Korbinian > > > > > > > > > > > > PS: this is my 1st Vote. If i've made any mistakes > please let > > > > > > me > > > know. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
