I've completed the most obvious changes I could think of. Can someone please review the commit I've done?
The JIRA tracker for this issue: http://issues.apache.org/jira/browse/WICKET-114 Martijn On 11/28/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
who did remove it then? Why move it to another package. Just keep it where it is, it is fine where it is. Just have the doc and example explain that the filter is the one to use johan On 11/28/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > Ah, good point. So we better get it back in 2.0 too then? Maybe move > to another package? > > Eelco > > > On 11/27/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > we need to keep the servlet in some shape or form for the osgi folks. > the > > osgi spec doesnt support filters. so a servlet that is a think wrapper > > around our filter should do the trick. > > > > -igor > > > > > > On 11/27/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > > > > > I would be ok with removing it. Maybe Johan wants to confirm? > > > > > > Eelco > > > > > > > > > On 11/27/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > > > I was giving the WicketFilter backport a shot, and I noticed that > the > > > > wicket servlet is completely gone from Wicket 2.x. > > > > > > > > Should we keep the servlet as a fallback for 1.x for existing > > > > applications? Will that have an adverse effect on our maintenance? > > > > > > > > As a side note: I noticed that much of our documentation is > > > > out-of-date regarding changed functionality in wicket-2.x. For > > > > instance I see a lot of references to WicketServlet where Filter is > > > > meant. Same goes for IWebApplicationFactory. I am able to fix most > > > > obvious errors, but not all. > > > > > > > > Martijn > > > > > > > > -- > > > > <a href="http://www.thebeststuffintheworld.com/vote_for/wicket > ">Vote</a> > > > > for <a href="http://www.thebeststuffintheworld.com/stuff/wicket > > > ">Wicket</a> > > > > at the <a href="http://www.thebeststuffintheworld.com/";>Best Stuff > in > > > > the World!</a> > > > > > > > > > > > >
-- <a href="http://www.thebeststuffintheworld.com/vote_for/wicket";>Vote</a> for <a href="http://www.thebeststuffintheworld.com/stuff/wicket";>Wicket</a> at the <a href="http://www.thebeststuffintheworld.com/";>Best Stuff in the World!</a>
