Just as a mental exercise, what will happen when we have this:
<a href="" wicket:id="foo">foo</a>
new AjaxLink(this, "foo") {
@Override protected void onComponentTag(...) {
super.onComponentTag(...);
tag.put("onclick", "alert('foo1');");
}
}.add(new SimpleAttributeModifier("onclick", "alert('bar1');"));
Which one gets precedent? The modifier or onComponentTag? Does it even
matter? Is the order of execution something that needs to be
documented as a fixed contract, don't we care, should we even care?
Martijn
On 12/6/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
I think using final for the onComponentTag and onComponentTagBody
methods have served their purposes fine during our wild two years of
development, but our core components are now stable enough to not have
to be worried about painting ourselves in the corner when we would
open up these methods (ie remove final).
Please vote:
[ ] yes, make all onComponentTag and onComponentTagBody methods of
the standard components in core non-final. This does leave the door
open for specific components to not adhere to that - I'm not proposing
a new standard - but if this wins we would remove final for most of em
[ ] no, leave the code as it is now
Eelco
--
<a href="http://www.thebeststuffintheworld.com/vote_for/wicket";>Vote</a>
for <a href="http://www.thebeststuffintheworld.com/stuff/wicket";>Wicket</a>
at the <a href="http://www.thebeststuffintheworld.com/";>Best Stuff in
the World!</a>
