1) make sure the default value of the springbean annot id property is either
null or an empty string
2) make sure that the constructed bean locator properly parsed that value
3) exercised getbeanname() of the locator to make sure no exceptions were
thrown if the default value of id attr was used
-igor
On 3/17/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
Yup. What did the test do?
Eelco
On 3/17/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> i didnt break that test, i think that was from martijn's change
>
> -igor
>
>
> On 3/17/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> >
> > Last reply:
> >
> > SpringBeanLocator has this:
> >
> > public final String getBeanName()
> > {
> > if (beanName == null || "".equals(beanName))
> > {
> > beanName =
getBeanNameOfClass(getSpringContext(),
> > getBeanType());
> >
> > }
> > return beanName;
> > }
> >
> > The test had this:
> >
> > assertTrue(locator.getBeanName() == null
> > || locator.getBeanName().length() ==
0);
> >
> >
> > Which doesn't make sense does it? And as there was no explanation at
> > all what that test is supposed to do it looked to me like it was fine
> > to remove it.
> >
> > Eelco
> >
> >
> > On 3/17/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > > There is zero explanation with the unit test, and there was just now
a
> > > breakage fixed that had to do with naming. Put it back if you want,
> > > but please run the tests first ok?
> > >
> > > Eelco
> > >
> > > On 3/17/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > > > I thought they were irrelevant. Aren't they?
> > > >
> > > > Eelco
> > > >
> > > >
> > > > On 3/17/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > > > > did you remove these checks because they were irrelevant or
because
> > you
> > > > > wanted to fix the build?
> > > > >
> > > > > -igor
> > > > >
> > > > >
> > > > > On 3/17/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > > > > >
> > > > > > Author: ehillenius
> > > > > > Date: Sat Mar 17 17:21:18 2007
> > > > > > New Revision: 519483
> > > > > >
> > > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=519483
> > > > > > Log:
> > > > > > fixed build
> > > > > >
> > > > > > Modified:
> > > > > > incubator/wicket/branches/wicket-1.x/jdk-1.5
> > > > > >
> >
/wicket-spring-annot/src/test/java/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
> > > > > >
> > > > > > Modified: incubator/wicket/branches/wicket-1.x/jdk-1.5
> > > > > >
> >
/wicket-spring-annot/src/test/java/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
> > > > > > URL:
> > > > > >
> >
http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/jdk-1.5/wicket-spring-annot/src/test/java/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java?view=diff&rev=519483&r1=519482&r2=519483
> > > > > >
> > > > > >
> >
==============================================================================
> > > > > > --- incubator/wicket/branches/wicket-1.x/jdk-1.5
> >
/wicket-spring-annot/src/test/java/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
> > > > > > (original)
> > > > > > +++ incubator/wicket/branches/wicket-1.x/jdk-1.5
> >
/wicket-spring-annot/src/test/java/wicket/spring/injection/annot/AnnotProxyFieldValueFactoryTest.java
> > > > > > Sat Mar 17 17:21:18 2007
> > > > > > @@ -71,8 +71,6 @@
> > > > > > proxy = factory.getFieldValue(field, obj);
> > > > > > locator = (SpringBeanLocator)
((ILazyInitProxy)
> > proxy)
> > > > > > .getObjectLocator();
> > > > > > - assertTrue(locator.getBeanName() == null
> > > > > > - || locator.getBeanName
().length()
> > == 0);
> > > > > > assertTrue(locator.getBeanType().equals(
Bean.class
> > ));
> > > > > > assertTrue(locator.getSpringContextLocator()
==
> > > > > > mockCtxLocator);
> > > > > > assertTrue(factory.getFieldValue(field, obj)
> > instanceof
> > > > > > ILazyInitProxy);
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
