sometimes it is nice to treat code as a blackbox and check your inputs and outputs. but maybe thats just me.
Sure. But in this case the test was flaky to start with. It wasn't clear what it tested for someone who didn't write the test, and by giving the code a closer look, it never actually tested what the author probably had in mind in the first place. Eelco
