Please vote +1/-1 all or per-item if you disagree with some but not others:
- make getRootModel(IModel) protected - i don't care much about this, it just seems like harmless functionality to inherit - make a public getRootModel() method that returns getRootModel(getModel()) - this one is necessary to my current annotation driven validation code. i have this exact method cut and pasted into my code and it seems like a method that could be useful to others and couldn't possibly hurt anything if it were public (although i think it should be final to prevent abuse). - add getNestedModel back to CompoundModel and rename that target field to nestedModel - consistency that eelco was wanting - IWrapModel->IModelWrapper - this is really an IModel that wraps another IModel, making it an IModelWrapper - IAssignmentAwareModel->IComponentAssignedModel - putting component in the name makes it more obvious that this is about component assignment and not some other kind of assignment. the model is being assigned to the component. assignment aware does not say anything about what kind of assignment the model is aware of. - IInheritableModel->IComponentInheritedModel - same thing here. a component inherited model brings to mind compound property models, which is right on, while IInheritableModel might suggest Java inheritance or some other kind of inheritance. this name suggests that this is a model that can be inherited by components. -- View this message in context: http://www.nabble.com/Vote%3A-A-few-small-changes-tf3494020.html#a9759022 Sent from the Wicket - Dev mailing list archive at Nabble.com.
