well, trunk convertees aren't using these interfaces too much.
sorry that this affects your chapter though. is there anyone
actually -1? if not, i'll go ahead and make these changes.
jon
Martijn Dashorst wrote:
>
> +0
>
> The biggest problem I have in renaming is that we mess again with
> trunk convertees, *and* that I have to revise a chapter I regarded
> finished.
>
> This may not be as big a change, but adds to the total. However, the
> names have changed for the better.
>
> Martijn
>
> On 3/30/07, Jonathan Locke <[EMAIL PROTECTED]> wrote:
>>
>>
>> Please vote +1/-1 all or per-item if you disagree with some but not
>> others:
>>
>> - make getRootModel(IModel) protected - i don't care much about this, it
>> just seems like harmless functionality to inherit
>>
>> - make a public getRootModel() method that returns
>> getRootModel(getModel())
>> - this one is necessary to my current annotation driven validation code.
>> i
>> have this exact method cut and pasted into my code and it seems like a
>> method that could be useful to others and couldn't possibly hurt anything
>> if
>> it were public (although i think it should be final to prevent abuse).
>>
>> - add getNestedModel back to CompoundModel and rename that target field
>> to
>> nestedModel - consistency that eelco was wanting
>>
>> - IWrapModel->IModelWrapper - this is really an IModel that wraps
>> another
>> IModel, making it an IModelWrapper
>>
>> - IAssignmentAwareModel->IComponentAssignedModel - putting component in
>> the
>> name makes it more obvious that this is about component assignment and
>> not
>> some other kind of assignment. the model is being assigned to the
>> component. assignment aware does not say anything about what kind of
>> assignment the model is aware of.
>>
>> - IInheritableModel->IComponentInheritedModel - same thing here. a
>> component inherited model brings to mind compound property models, which
>> is
>> right on, while IInheritableModel might suggest Java inheritance or some
>> other kind of inheritance. this name suggests that this is a model that
>> can
>> be inherited by components.
>>
>>
>> --
>> View this message in context:
>> http://www.nabble.com/Vote%3A-A-few-small-changes-tf3494020.html#a9759022
>> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>>
>>
>
>
> --
> Learn Wicket at ApacheCon Europe: http://apachecon.com
> Join the wicket community at irc.freenode.net: ##wicket
> Wicket 1.2.5 will keep your server alive. Download Wicket now!
> http://wicketframework.org
>
>
--
View this message in context:
http://www.nabble.com/Vote%3A-A-few-small-changes-tf3494020.html#a9771729
Sent from the Wicket - Dev mailing list archive at Nabble.com.
