this does mean that IF the session is used in another page from another
pagemap
we are clearing also the feedbackMessagges of that request.

Yep. See my commit comments about 'agressive' cleanup. There can be
disagreement for specific situations whether this is the best
implementation, which is why it is put in an overridable method. But I
rather cleanup agresively so that we avoid having memory leaks.

i know it is not very likely that we will see that happening but it is
possible
that 2 threads are interacting with the same feedbackMessages now.

Do you have a case? If there is a potential concurrency problem, we
should fix it. And maybe the conclusion would be that a non-agressive
cleanup is better. But for the moment, I prefer to stay on the safe
side.

Eelco

Reply via email to