cases will be rare but possible. it would require two threads in two different pagemaps processing simultaneously.
so user goes to a form page, opens it in a new tab, submits in first, and then submits in the other. now one tab can have its feedback messages missing. or maybe a user working in multiple tabs and having two different pages with forms on them. or maybe not even forms, just some status feedback messages can also be missing. should we fix this? i think so. -igor On 4/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> this does mean that IF the session is used in another page from another > pagemap > we are clearing also the feedbackMessagges of that request. Yep. See my commit comments about 'agressive' cleanup. There can be disagreement for specific situations whether this is the best implementation, which is why it is put in an overridable method. But I rather cleanup agresively so that we avoid having memory leaks. > i know it is not very likely that we will see that happening but it is > possible > that 2 threads are interacting with the same feedbackMessages now. Do you have a case? If there is a potential concurrency problem, we should fix it. And maybe the conclusion would be that a non-agressive cleanup is better. But for the moment, I prefer to stay on the safe side. Eelco
