hmm this could go wrong now:

           setFlag(FLAG_RENDERING, true);
           onBeforeRenderChildren();


we first set the flag in rendering then call the onBefore on all the childs

so the parent is already i render mode (can't be changed) but the childs
should be able to still alter the state
thats a bit strange i think the rendering flag should be on true only if all
the childs are also called? agree?

johan


On 5/14/07, Jonathan Locke <[EMAIL PROTECTED]> wrote:



I committed a fix to this this morning that I have confidence in.  Still
having problems due to this refactor.  Who did it?


Jonathan Locke wrote:
>
>
> unless you can get to this fast, i'm going to guess a fix because
> we're blocked on this.
>
>
> Johan Compagner wrote:
>>
>> will check it out asap
>>
>> On 5/12/07, Jonathan Locke <[EMAIL PROTECTED]> wrote:
>>>
>>>
>>>
>>> Opened new blocking bug:
>>>
>>> https://issues.apache.org/jira/browse/WICKET-558
>>>
>>>
>>> Jonathan Locke wrote:
>>> >
>>> >
>>> > Because components are created in onBeforeRender in list views (it
>>> calls
>>> > populateItem then), it is necessary for AJAX renderings now to call
>>> > beforeRender on every component to be updated before proceeding with
>>> the
>>> > render.
>>> >
>>> > It looks like AjaxRequestTarget.respondComponent should call before
>>> render
>>> > on the component tree it's about to render.  But I'm unsure if this
is
>>> the
>>> > right place to make the change.  Johan can you look at this since
you
>>> were
>>> > doing this refactor and probably know all the details?
>>> >
>>> >
>>>
>>> --
>>> View this message in context:
>>>
http://www.nabble.com/New-attach-%3EbeforeRender-refactor-breaks-ajax-updating-of-list-views-tf3729131.html#a10443272
>>> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>>>
>>>
>>
>>
>
>

--
View this message in context:
http://www.nabble.com/New-attach-%3EbeforeRender-refactor-breaks-ajax-updating-of-list-views-tf3729131.html#a10609034
Sent from the Wicket - Dev mailing list archive at Nabble.com.


Reply via email to