Except when you use the RequiredTextField then the check was not done suddenly.
i committed a change that the basic textfields and its basic subclasses always checks for the type
And that can be overridden by overriding a method.
johan
On 4/16/06, Matej Knopp <[EMAIL PROTECTED]> wrote:
I see, it really doesn't.
Should there even be the check? I mean input without type='text' is
valid, right? Adding this check could break a lot of existing code.
-Matej
Johan Compagner wrote:
> RequiredTextField doesn't check currently.
>
> johan
>
>
> On 4/16/06, *Matej Knopp* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote:
>
> What subclasses? There are only 3 subclasses of TextField in current
> wicket core, HiddenField, PasswordTextField, and RequiredTextField.
> HiddenField and PasswordTextField _do_ check for input type.
>
> -Matej
>
> SourceForge.net wrote:
> > Bugs item #1470901, was opened at 2006-04-15 16:58
> > Message generated for change (Tracker Item Submitted) made by
> Item Submitter
> > You can respond by visiting:
> >
> https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1470901&group_id=119783
> <https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1470901&group_id=119783 >
> >
> > Please note that this message will contain a full copy of the
> comment thread,
> > including the initial issue submission, for this request,
> > not just the latest update.
> > Category: core
> > Group: 1.2
> > Status: Open
> > Resolution: None
> > Priority: 5
> > Submitted By: Blake Day (blakeday)
> > Assigned to: Nobody/Anonymous (nobody)
> > Summary: type attribute is not checked when overriding TextField
> >
> > Initial Comment:
> > TextField requires the type="text" attribute for
> > <input> elements; however, subclasses do not.
> >
> > I guess the appropriate behavior would be to check for
> > the attribute if TextField is subclassed as well.
> >
> > Here is the code that does the check:
> >
> > // If this is not a subclass (PasswordTextField)
> > if (getClass() == TextField.class)
> > {
> > // check for text type
> > checkComponentTagAttribute(tag, "type", "text");
> > }
> >
> >
> ----------------------------------------------------------------------
> >
> > You can respond by visiting:
> >
> https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1470901&group_id=119783
> <https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1470901&group_id=119783>
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by xPML, a groundbreaking
> scripting language
> > that extends applications into web and mobile media. Attend the
> live webcast
> > and join the prime developer group breaking into this new coding
> territory!
> >
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 >
> > _______________________________________________
> > Wicket-develop mailing list
> > [email protected]
> <mailto:[email protected]>
> > https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language
> that extends applications into web and mobile media. Attend the live
> webcast
> and join the prime developer group breaking into this new coding
> territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 >
> _______________________________________________
> Wicket-develop mailing list
> [email protected]
> <mailto: [email protected]>
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>
>
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
