But... I still do not see the need to pass the session in these methods. For the same reason you removed the requestCycle parameter from the validate method in IValidator, we can do without the session parameter in attach/ detach. It blurs the API. Furthermore, having used/ implemented a lot of these models allready (must be 50+ encounting) in projects, I never needed either the request cycle or the session object, so my guess is that the session is needed in very rare cases indeed. So why pass it then?
What do you think Johan and Juergen? Have you had the cases where you actually depended on the request or session in attach/ detach?
Eelco
Jonathan Locke wrote:
actually, i may have a different fix now that preserves the Session parameter by improving Component.getSession() so that it always works.
have you already checked this in? if not, please don't and i can check in my fix.
Eelco Hillenius wrote:
I am having problems with using detachable models in the constructor of components (and I do that often) as a result of the recent changes.
I propose (again) to remove the parameters alltogether, and thus have attach() and detach(). Either this, or - if you think performance will be a real problem here - the requestCycle parameter back again.
Eelco
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
