oh, one last thing... i really like the use of CharSequence for parsed stuff. this was smart. but i don't see the value in making StringResource's type contentType parameter a CharSequence. i would make it a simple String so people are less confused by it. also, a comment that you can pass in a String for the CharSequence would help novices.
Jonathan Locke wrote:
this class seems like a good idea!
however, it makes me wonder if we shouldn't rename IStringResourceLoader and friends to IStringLoader and friends because these classes have nothing to do with StringResource... and maybe rename the package to stringloader... this would at least make things clearer because with this new class we now have two totally unrelated concepts of "string resource"... which is a sure bet for confusion among users.
seems like last-mod time should be construction time of the object, not null.
also, since wicket.util is generic, it seems like this:
this(string, "text/html");
should be
this(string, "text");
and usages that care about the subtype html should use the two arg constructor.
i suppose i might be a little purist though, so i didn't make the change. up to you, juergen! ;-)
okay, i keep getting distracted by wicket... i gotta get back to my other stuff!! ;-)
jon
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
