Of course we can make ListView the PageableListView.

Then we have 2 things:

Loop: this one just goes from 0-size() nothing fancy should be used as an iterator. ListView: is a pageable Loop that also gives some more control of the ListItemModel (and maybe some more)

But then listview gets currentPage and numberOfRows (default both -1)

But as i said the Pageable component itself (the ListView) controls the number of rows it displays not the component that just gets that Pageable component to do something with it. (what ever: jump to next, last or first)

So if ListView is pageable you get something like this:

ListView lv = new ListView();
lv.setRowsPerPage(30)
PageNavigator pn = new PageNavigator(lv);


attaching a PageNavigator to a listview that has the default rows per page (-1) just doesn't make sense....

Also i don't like that PageXXX thing in all the names
We already have Pages in wicket. We shouldn't use that name i think
But who has a better idea??

johan


Igor Vaynberg wrote:
Yes, the PageableListView will become a listview but behaves like the old
listview by default, once its attached to the navigator it (the navigator)
would set the rowsperpage property or whatever that ends up being called.
Maybe add setRowsPerPage to Ipageable? Not sure what the best way to do this
is, but it would sure be nice not to have the class tuples.

-Igor
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Johan Compagner
Sent: Friday, August 12, 2005 1:35 PM
To: [email protected]
Subject: Re: [Wicket-develop] IPageable

hmm don't know this yet
Then ListView just becomes PageableListView.

And you don't attach something to ListView.. it is the other way around you attach PageableListview to a one of the navigator components.

johan


Igor Vaynberg wrote:
A little off topic, but I was under the impression that
with this new
framework there wont be a need for PageableListView as
ListView will
be able to handle the paging itself - or maybe merge them into one?

I know this was rejected before, but maybe something as simple as attaching a paging navigator to a listview makes it
pageable and the
pagesize can be set up in the paging navigator.

-Igor
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Johan Compagner
Sent: Friday, August 12, 2005 1:23 PM
To: Wicket Developer List
Subject: [Wicket-develop] IPageable

I am busy with that now.

It is pretty much the same implementation we already have in the

wicket.markup.html.list package

So i moved it to

wicket.markup.html.navigation.paging

But if i make PageableListview implement IPageable then a lot does change (we will break a lot that use PageableListview and its navigator)

I also have the same question igor did a while ago (didn't
know if it
got answered) Why is a NavigationLink not just returning its own page? It is as far as i know always the same page as the list
view is on.
Or are there really situations that you are on Page X with
the next>>
link and you go then to Page Y where you display the Pageable component?

If we need support for a different page then of course this can be handled through the constructor but i want to know if this
is really
needed?

Now we have 4 kind of components:

1> PageNavigation., this one can display 1,2,3,4,5 those are:
2> PageNavigationLink, goes to one page (1,2,3 or first,last)
3> PageNavigationIncrementLink, -N or +N

and 4 is just a combination of those the PageNavigator. (just and easy impl to get:
<< < 1 2 3 4 > >>

Of course if you have a DetailPage that has a Form that is
Pageable
then you only need the IncrementLink (next/prev record)

Besides these components we now also need a
PageRangeNavigationLink?
(that can display 1-10 , 11-20)

For this we need another interface

interface IRangePagable extends IPageable {
    Range getRange()
}

class Range
{
    public Range(int start, int end)
     getStart() return start;
     getEnd() return end;
}

Then if PageNavigation sees a IRangePagable then it will generate PageRangeNavigationLink instead of PageNavigationLink

Comments?

johan







-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing
Projects & Teams
* Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop





-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing
Projects & Teams
* Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop







-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to