+1 on #2 (non-binding)

Francis

On 10/26/05, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
All,

On the user list, we had a discussion on the lack of good feedback
when markup isn't found, or invalid. This resulted in three different
tracks:

1. fix the error reporting, as previously we had a nice errorpage
displaying the exact misplaced markup

2. a proposal by Igor for introducing several subclasses of
WicketRuntimeException for different cases:

> MarkupNotFoundException - this is pretty clear. Message should say
> something like it does now: Markup for component x not found.

> MarkupParseException - this is when there is a problem with parsing
> the html template. The message should name the filename and say
> exactly where in that file the problem is.

> InvalidMarkupException - gets throw when there is a wicket-releated
> markup problem. I.E. a component is attached to a tag it does not
> support. The message should be something like: component x does
> not support markup tag of type y, or something similar.

3. merge the error messages from 'caused by' exceptions into the outer
exception, a la Spring, and don't create new exceptions, but rethrow
the original exception when possible.

I'd like to propose we implement and fix all 3 tracks in the 1.1
timeframe, as this helps us and future users with implementing Wicket
applications. Juergen is already fixing 1, and this should work in the
1.1 slot, as it is a regression from previous functionality.

The vote is:
- release Wicket 1.1 with fix 1 (and possibly 3) on thursday evening
- postpone Wicket 1.1 until this weekend (sunday) and fix 1, 2 and 3

May I have your votes please?

Martijn


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of 2005
Visit http://www.jboss.com/services/certification for more information
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to