Cool. Eelco
On 7/7/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > It is almost only refactoring. It simplies dealing with ComponentTag > and removes quite some "elem instanceof WicketTag" tests. > > Currently we have > MarkupElement > RawMarkup > ComponentTag // tags with wicket:id > WicketTag // tags with wicket namespace > > This structure kind of implies that WicketTags must have wicket:ids as > well which of course is not the case. And <head> and <body> don't have > a wicket:id either but were still ComponentTags. We would have needed > another class if were following that same approach. Actually the idea > of having separate implementations for different type of tags was > good, but I guess the implementation wasn't. I always felt using it is > a little bit awkward. Instead of extending the structure I now moved > the convinience methods from WicketTag into ComponentTag, added two > flag to ComponentTag for "has wicket namespace" and "is internal tag" > (<head>, <body>). Now the differentiation is no longer with the type > but with a flag in ComponentTag. > The reason why it touches quite some files is because most of the > resolvers, handlers and some of the render code in MarkupContainer > referenced it. > > Juergen > > On 7/7/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > I'm fine with you committing anything you think makes Wicket better. > > What's the change exactly though? And the problem it solved? > > > > Eelco > > > > > > On 7/7/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > > > I finally got rid of WicketTag and would like to commit the code. It > > > is mostly related to markup handling and the changes should be wicket > > > internal only except for people who wrote there own resolvers. But I > > > guess that are only very few. Any objections against committing it to > > > 2.0`? > > > > > > Juergen > > > > > > Using Tomcat but need to do more? Need to support web services, security? > > > Get stuff done quickly with pre-integrated technology to make your job > > > easier > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > _______________________________________________ > > > Wicket-develop mailing list > > > Wicket-develop@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > > Wicket-develop mailing list > > Wicket-develop@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
