> * custom resource loading with more control over caching (backport from 2.0)
The issue has not been solved yet. If lookupResult.getCacheKey() !=
null than caching is basically disabled. the markup is stored in the
cache with the key, but the new key is never used for lookup. The
reason is:
- first check the cache on the "default" cache key
- if not exist than load the markup
- if lookResult.getCacheKey() != null than save the markup in the
cache with the new key
What we need to do, I think, is to ask the container for the cache
key first. A separate function independent from
container..newMarkupResourceStream(). And if
container.getMarkupCacheKey() == DONT_CACHE than caching would be
disabled. Actually it means that MarkupResourceStreamLookupResult
would not be needed as well.
Juergen
Current code:
// Look up markup tag list by class, locale, style and markup
type
final CharSequence key = markupKey(container, clazz);
IMarkup markup = markupCache.get(key);
// If no markup in the cache
if (markup == null)
{
synchronized (markupCache)
{
markup = markupCache.get(key);
// If no markup is in the cache
if (markup == null)
{
// Ask the container to locate its
associated markup
final MarkupResourceStreamLookupResult
lookupResult = container
.newMarkupResourceStream(containerClass);
On 8/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> I'd like to add one, though I'd like Juergen to confirm whether it is
> easy enough to do:
>
> * converter simplifications (backport from 2.0)
> * lazy session (backport from 2.0)
> * bookmarkable goodies - forms/links (backport from 2.0)
> * second level cache (backport from 2.0)
> * replace pagemap with window (new in 1.3 and 2.0)
> * some sort of framework for ssl support (new in 1.3 and 2.0)
> * url on error pointing to offending page instead of error page (new
> in 1.3 and 2.0)
> * session expiration error handling for ajax requests (new in 1.3 and 2.0)
> * custom resource loading with more control over caching (backport from 2.0)
>
> Re: this last feature. Juergen, do you still have doubts about how
> this is done in 2.0? Looks to me like it works fine enough.
>
> Eelco
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Wicket-develop mailing list
> Wicket-develop@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
