-Igor
On 8/14/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
Ok i have implemented igors patch and sorted out the problem by resetting the response (if the response can handle that)
It should work fine now in the situations i can think of:
1> no redirect (one_pass_render or bookmarkable request), buffered response: the buffer is reset (build up string and redirect url)
2> redirect_to_buffer: the redirect buffer is another buffer by itself, so the reset even doesn't have any effect.
3> normal_redirect strategy: this is in the end the same effect as <1>
The only thing that will not work if the response is not a buffered response and it is a <1>. (the redirect_to_buffer wil still work)
Because i can't reset it. But now i think about it. The previous behaviour didn't work at all.
Because then we had already written to the servlet output writer. And then a redirect to an ExceptionPAge would happen
But this can't be done, because the response is already committed. So the exception page would generate again an exception.
So i guess just writting the error output directly after the partial page is even the best solution.
So i want to commit this for 1.2.2 also because it seems to be fixing even a potential problem.
johanOn 8/13/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
On 8/13/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote:On 8/13/06, Johan Compagner <[EMAIL PROTECTED]> wrote:Buf if we are in a bookmarkable request (or another render strategy) which is rendered immediantly then we have 2 ways i gues:
1> buffered output: We have to reset the buffered output somehow completely.. (maybe the DefaultExceptionResponseStrategy should just set a new buffer)
you mean set a new buffered response object?
yes, or reset the current one.
Can you try your current code? Just hit a bookmarkable url (so there is no redirect) and in the rendering process (onComponentTag of some component)
throw an exception. What is then the output currently?
johan
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
