it takes just a few lines of code to build, and if we provide it people will want a solution for lets say two attributes and so on. i would rather not open that door - i mean here is the whole thing, count the lines, why cant the users implement this themselves?

class TagModifier extends WebMarkupContainer {
   private final String attr;
   private final String val;

   public TagModifier(String id, String attr) { this(id, attr, null); }

   public TagModifier(String id, String attr, String val) {
       super(id); this.attr=attr; this.val=val;
   }

   protected String getVal() { return val; }

  protected void onComponentTag(ComponentTag tag) {
       tag.put(attr, getVal());
  }
}

was that so hard? do we really need to start providing things like this?

-Igor



On 8/15/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
On 8/14/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> i think 1 is trivial and should not be part of the core. our api has a
> pretty large surface for the users to learn already and i dont think we need
> to throw such things in.

I would usually agree with that, but in this case I'd be +1 for the
addition. TagModifier looks a lot better to me than
WebMarkupContainer, the latter being a base class, and TagModifier's
name only implying it is for a specific purpose. *If* we would agree
to put this in the project, we state in it's API docs that it is not
mean for anything else.

Eelco

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to