And don't add the @Override
Martijn
On 9/6/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> no doesn't break any binary thing, it should be a drop in replacement
> only the behaviour is slightly difference that the streams are getting to be
> closed on the end of a request (as it should!)
>
> i am +1
>
> Only this should be changed for the patch:
>
> + @Override
> + protected final void onDetach()
> + {
> + super.onDetach();
> +
> + fileUpload.closeStreams();
> + }
>
> don't make it final. Because that could be a binary drop in replacement
> problem.
>
> johan
>
>
>
>
> On 9/5/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote:
> >
> Does it break binary compatibility?
>
> Martijn
>
> On 9/5/06, Frank Bille <[EMAIL PROTECTED]> wrote:
> > Hey
> >
> > If you just take you time to skim the bug report[1] then I would like to
> > know if it would be ok to backport the fix (the patch attached to it or
> > revision 7227 in svn) to 1.x and therefore 1.2. It would be ok for 1.3 I
> > think, but it would also be quite good for 1.2 because it would *maybe*
> fix
> > a lot of problems the user could have with non-closed input streams.
> >
> > So: +/- on backporting it to 1.x (1.2)?
> >
> > Frank
> >
> > [1]:
> http://sourceforge.net/support/tracker.php?aid=1543832
> >
> >
> -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job
> > easier
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> >
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> >
> > _______________________________________________
> > Wicket-develop mailing list
> > Wicket-develop@lists.sourceforge.net
> >
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >
> >
> >
>
>
> --
> Download Wicket 1.2.2 now! New Ajax components: Tree, TreeTable and
> ModalWindow
> -- http://wicketframework.org
>
> -------------------------------------------------------------------------
>
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Wicket-develop mailing list
> Wicket-develop@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>
> _______________________________________________
> Wicket-develop mailing list
> Wicket-develop@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>
>
>
--
Download Wicket 1.2.2 now! New Ajax components: Tree, TreeTable and ModalWindow
-- http://wicketframework.org
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
