Of course. I think internalDetach would be the right place. It says that it's for internal use only and not part of the API. So if the user overrides this he's asking for trouble. Also because he could just as well use the onDetach.

internalDetach it is then.

Frank


On 9/6/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
i don't like such a onDetached. Then people has to learn to implement that method for that specific component.
Just learn to use the super call.
Eclipse if you generate the stub auto generates it for you the super call.
So to keep introducing all those methods is horrible. But don't we have a internalDetach for that??
So that we can implement internally our own things and let onDetach be for the outside word?

johan


On 9/6/06, Frank Bille < [EMAIL PROTECTED]> wrote:
On 9/6/06, Eelco Hillenius <[EMAIL PROTECTED] > wrote:
> And killing the onDetach() for subclasses could be bad in the future.

Yeah, we should only finalize such things if it would be plain wrong
if sub classes would implement that, which is not the case here.

Agreed,

If you want to ensure no subclass ever messes up the call to onDetach,
we can always finalize onDetach, and let that method class onDetached
or whatever new, empty method would come in place. That's protective
but messes up the API a bit.

I'll do that. I think it's a good way to let Wicket provide a good and safe framework and still let the user do what he wants


Frank

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop




-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to