wasn't there talk about a common validation framework?
i think it ended up being just that - talk :)
start it up again ;)
Everybody start the vote:
[X] Igor leading common validation framework
[ ] can't choose anything else.
you can do what you want now also pretty easy.
Only one extra adapterclass inbetween:
FormComponent.add(new ServiceLayerValidator(new ZipcodeValidator()));
yes, but we already have all the nice validators in wicket - like string validator, pattern validator, etc. i would have to reimplement all those for no good reason.
Ahh so you do want to change all our validators and all the validators that are currently written by others:
So you want to change
void validate(final FormComponent component);
to
void validate(final ValidationContext component);
(i first thought it was more an add on, so that you can reuse validators you already have from the service layer on both sides)
But some general change/addition into form component is fine by me
(i do like that second approach of an extra method returning the ValidationContext instead of letting it implement it)
yes i dont particulary like it either, but it means we dont have to reshuffle any method names. if we dont mind doing that then formcomponent can implement it directly.
Ok but if we let FormComponent implement IValidationContext
then please, please try to map it on existing methods.. I really don't like another getValueXXXX method on FormComponent
The current X number of input/output value methods we already have is already very confusing.
And then the right method would be getConvertedValue() which is for that interface a bit strange i know. Rename getConvertedValue?
johan
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
