Can't that be a normal class what would the interface really give us?
johan
On 9/7/06, Igor Vaynberg <
[EMAIL PROTECTED]> wrote:
ok, so....
IValidatable<T> { T getValue(); error(IValidationError error); }
IValidationError { String getMessage(ILocalizer localizer); }
ILocalizer {
String getMessage(String key);
String getMessage(String key, Map params);//not sure if need to have one that also takes params but would be nice
}
advantage of IValidationError is that we can get rid of the bunch of ugly error() messages in abstract validator that are messy.
thoughts?
-IgorOn 9/6/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:that sounds reasonable, context is the standard term that all the other validation frameworks use so i figured it would be familiar to people.
-IgorOn 9/6/06, Jonathan Locke <[EMAIL PROTECTED]> wrote:
yeah. i dislike the word 'context' in general because it rarely
seems to add anything intuitive. what about just IValidatable?
something that is validatable can be validated by a validator.
that makes more sense to me.
igor.vaynberg wrote:
>
> actually i18n comes into play so i think i would like
>
> void error(String key, Map params)
>
> -Igor
>
> On 9/5/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote:
>>
>> yeah, that makes sense to me.
>>
>> IValidationContext FormComponent.getValidationContext() {
>> return new IValidationContext() {
>> T getValue() { return getConvertedInput(); }
>> void error(String s) { FormComponent.this.error (s); }
>> }}
>>
>> -Igor
>>
>>
>>
>> On 9/5/06, Jonathan Locke < [EMAIL PROTECTED]> wrote:
>> >
>> >
>> >
>> > the list and map look like implementation details to me.
>> >
>> > isn't the component itself the validation context? so something more
>> > like:
>> >
>> > IValidationContext<T>
>> > {
>> > T getValue();
>> > void error(String);
>> > }
>> >
>> > then an adaptor class connects the two methods to the component.
>> >
>> > jon
>> >
>> >
>> > igor.vaynberg wrote:
>> > >
>> > > i am working on an app that uses wicket and remoting, so i need to do
>> > > validation in wicket and in the business layer. the problem is that
>> > our
>> > > validators do not translate well into the business layer, and i hate
>> > to
>> > > write them twice. i can do all the validation in the service layer,
>> > but
>> > > then
>> > > it is not trivial to map the errors back to the form components if
>> you
>> >
>> > > need
>> > > formcomponent precise errors for the ui.
>> > >
>> > > to ease the pain i was thinking of something like this
>> > >
>> > > IValidationContext { Object getValue(); void error(List,Map); }
>> > >
>> > > and FormComponent implements IValidationContext
>> > > where getValue would map onto getConvertedInput() and error would map
>> > > directly (obviously we already have getvalue() so it would have to be
>> > > called
>> > > something else)
>> > >
>> > > it still lacks but at least i would be able to reuse the same
>> > validators
>> > > in
>> > > a non-wicket context. it also would be great to provide a seperate
>> > > wicket-validation.jar or some such.
>> > >
>> > > what do you guys think? i havent thought this through in any amount
>> of
>> > > detail, so perhaps there are better ways to do this.
>> > >
>> > > error(List,Map) is a bit dirty as well, maybe it can be cleaned up
>> > > somehow.
>> > >
>> > > it will also make validators easier to understand because when you
>> see
>> > > validate(FormComponent) your first thought is "what the hell do i do
>> > now?"
>> > > where some sort of IValidationContext would be more expressive and
>> > guide
>> > > the
>> > > user better.
>> > >
>> > > -Igor
>> > >
>> > >
>> >
>> -------------------------------------------------------------------------
>> > > Using Tomcat but need to do more? Need to support web services,
>> > security?
>> > > Get stuff done quickly with pre-integrated technology to make your
>> job
>> > > easier
>> > > Download IBM WebSphere Application Server v.1.0.1 based on Apache
>> > Geronimo
>> > >
>> >
>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>> > > _______________________________________________
>> > > Wicket-develop mailing list
>> > > Wicket-develop@lists.sourceforge.net
>> > > https://lists.sourceforge.net/lists/listinfo/wicket-develop
>> > >
>> > >
>> >
>> > --
>> > View this message in context:
>> > http://www.nabble.com/wicket-validators-2.0-tf2218528.html#a6156683
>> > Sent from the Wicket - Dev forum at Nabble.com .
>> >
>> >
>> >
>> >
>> -------------------------------------------------------------------------
>> > Using Tomcat but need to do more? Need to support web services,
>> > security?
>> > Get stuff done quickly with pre-integrated technology to make your job
>> > easier
>> > Download IBM WebSphere Application Server v.1.0.1 based on Apache
>> > Geronimo
>> >
>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>> >
>> > _______________________________________________
>> > Wicket-develop mailing list
>> > Wicket-develop@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/wicket-develop
>> >
>>
>>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Wicket-develop mailing list
> Wicket-develop@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>
>
--
View this message in context: http://www.nabble.com/wicket-validators-2.0-tf2218528.html#a6174644
Sent from the Wicket - Dev forum at Nabble.com .
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
