first of all always go through the URI when making a File out of a URL
getFile() doesn't work. (empty spaces, encoded you name it)

One problem if we completely skip the jars... More and more people use OSGI and bundles
those can be updated on the fly. But if we don't see that then we never serve the new file.

So just not testing any kind of jar will break stuff.

johan



On 9/16/06, Jean-Baptiste Quenot <[EMAIL PROTECTED]> wrote:
* Johan Compagner:

> First of  all you  also should do  that in  the lastModifiedTime
> call of the URLResourceStream class.

Right, thanks for pointing out.   The problem is more serious than
I thought first, because the  file descriptor leak also happens in
DEPLOYMENT mode, although a lot less.

In  DEVELOPMENT mode  templates  in JAR  files  are checked  every
second  (by default),  so  file  leaking is  very  quick.  But  in
DEPLOYMENT mode, it's only when  loading other resources (CSS, JS,
images) that the leak occurs.   And because of browser caching you
don't notice the leak a lot.

I have a very radical solution to that: prevent to update the last
modified time  for resources in JARs  as it doesn't make  a lot of
sense anyway to reload resources from JARs.  I couldn't figure out
a more elegant approach.

Please find patch attached.  If you  think it's worth, I'll add it
to the SF tracker.
--
     Jean-Baptiste Quenot
aka  John Banana Qwerty
http://caraldi.com/jbq/


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop




-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to