> > 2) If we do (1) we can get rid of the duplicate > onbeginrequest methods > > by using an impl of iprimarykeyprovider that uses the long counter. > > > Yes there is a synergy but the current methods are still > quite different - have to think abaout it. In case we make no > model mapping (a removeall for no iprimarykeyprovider) than > the counter is not realy needed.
Indeed, simply removeall() and use a local counter for the ids. We can still wrap it in a iprimarykeyprovider. > Another thing: > Maybe in onRender instead of rendering over the viewSize we > could use the Component.size(). I thought of this because I > am a bit worried about the stability of viewSize. With a DB > you will generally not read in a SERIALIZED transaction, so > if someone else removes an entry between > getItemCount() and the actual iterator-select than you could > end up with a bigger viewSize than there are items in the > iterator -> items for rendering. I am not sure if this is too > much concern any thoughts? If we do this we would have to lock the add()/remove()/etc methods in the dataview. Or what we can do is record the number of actual dataitems added in onbeginrequest in a field, and use that in render(). Thoughts? -Igor ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-user
