The testcases do pass, but the problem still remains. You should be able to reproduce this on your end. Add a component into a page with setVisible(false), then add a breakpoint inside its onComponentTagBody() method and note that this will still get invoked and the tag will get rendered by Component.renderComponent(final MarkupStream markupStream)

        I think the bug is actually on Component line 1849 which reads:

                // Render open tag
                if (getRenderBodyOnly() == false)
                {
                    renderComponentTag(tag);
                }

Gili

Juergen Donnerstag wrote:
that is correct and based on the test cases it should work. Do the
test cases succeed on your pc?

Juergen

On 9/12/05, Gili <[EMAIL PROTECTED]> wrote:

      I think you understood me. What I am saying is that a component with
isVisible()==false still shows up on the page. This isn't supposed to
happen, right?

Gili

Juergen Donnerstag wrote:

Not sure I understand what you. Previously setVisible did NOT prevent
the component from rendering. It simply got written into a
NullResponse. Due to user requests (you included) we changed it.
Invisible components (incl. associated AttributeModifiers) don't get
rendered at all now.

Juergen

On 9/12/05, Gili <[EMAIL PROTECTED]> wrote:


Hi,

     I've got a meta redirect tag. In older releases of Wicket, if I invoked
setVisible(false) on the tag, its nested AttributeModifier would become
invisible too. With RC1, the tag and its nested AttributeModifier are
rendering even though its state is:

redirectPage=[Component id = redirectPage, page =
desktopbeautifier.web.contactus.Page, path =
1:headerContributor:redirectPage.WebComponent, isVisible = false,
isVersioned = true]

     I can't see how this could be anything but a bug. Any ideas?

Gili
--
http://www.desktopbeautifier.com/


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user


--
http://www.desktopbeautifier.com/


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user


--
http://www.desktopbeautifier.com/


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to