But is ExternalLink's ability to replace its body ok or is it bad? I actually thought that was the only way it worked, but now I see that it switches in onComponentTagBody depending on whether a label was specified in the constructor. (There's no way to know this without looking at the source.)
I think I'd rather see the "label" constructor be deprecated, just for consistency with Link. Nathan Igor Vaynberg wrote: > <a href="#" wicket:id="link">this is some text</a> > or > <a href="#" wicket:id="link"><span wicket:id="label"></span></a> > > this works for Link or ExternalLink, no webmarkup containers, etc. > > -Igor > > > On 1/17/06, Nathan Hamblen <[EMAIL PROTECTED]> wrote: >> >> I use ExternalLink all the time. You're saying we should instead have >> spans >> nested in anchor tags, represented in Java as Label objects nested in >> WebMarkupContainer objects, with attribute modifiers on href? >> >> Nathan >> >> Juergen Donnerstag wrote: >> >> > ExternalLink realy is a convinience component only and should only be >> > used for links pointing outside of wicket. May be we should move it >> > into extensions because it is not a general purpose component and >> > probably not used very much anyway. And because it replaces the tags >> > body with whatever test is provided. That is not the standard wicket >> > way. It just saves a little bit of coding. >> > >> > Juergen >> > >> > On 1/17/06, Nathan Hamblen <[EMAIL PROTECTED]> wrote: >> >> For ExternalLink objects I can specify the link's text directly, and I >> >> can't embed a span to do the same. With Link and its subclasses, I can >> >> ONLY embed span (or other) tags. Right? That's a pretty striking >> >> functional difference between related classes. >> >> >> >> I see this has come up on the list once before (subject: HyperLink >> Text) >> >> but wasn't resolved. It's pretty important to people learning Wicket >> >> to be able to specify a link's text in the same way, whether it's >> "internal" >> >> or external. And in unusual cases where you have a link in markup >> >> whose text varies and whose target page is sometimes in Wicket, >> >> sometimes >> not, >> >> you have to resort to some fairly ridiculous coding. (This is in the >> >> parent >> >> page template of a half-migrated app, if you're trying to dream up >> >> the scenario.) >> >> >> >> Nathan ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
