So,
Index:
/Users/eelcohillenius/Documents/workspace/wicket/src/java/wicket/util/string/JavascriptUtils.java
===================================================================
---
/Users/eelcohillenius/Documents/workspace/wicket/src/java/wicket/util/string/JavascriptUtils.java
(revision
5459)
+++
/Users/eelcohillenius/Documents/workspace/wicket/src/java/wicket/util/string/JavascriptUtils.java
(working
copy)
@@ -28,10 +28,10 @@
public class JavascriptUtils
{
/** Script open tag */
- public final static String SCRIPT_OPEN_TAG = "<script
type=\"text/javascript\">";
+ public final static String SCRIPT_OPEN_TAG = "<script
type=\"text/javascript\"><![CDATA[";
/** Script close tag */
- public final static String SCRIPT_CLOSE_TAG = "</script>";
+ public final static String SCRIPT_CLOSE_TAG = "]]></script>";
/** The response object */
private Response response;
Should fix that. Before comitting something like that, I'd like to
make sure that won't introduce additional problems though.
Eelco
On 4/18/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> Also, will this give trouble for pages that are not explicitly XHTML
> complient?
>
> Eelco
>
> On 4/18/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > Without the // I think?
> >
> > So instead of
> > //<![CDATA[
> > function isXhtmlFriendly() {
> > alert('Yes, I am XHTML friendly');
> > alert('quotes ", less than <, and ampersand & used in this javascript
> > code do not yield to XHTML validation error');
> > }
> > //]]>
> >
> > it's
> >
> > <![CDATA[
> > function isXhtmlFriendly() {
> > alert('Yes, I am XHTML friendly');
> > alert('quotes ", less than <, and ampersand & used in this javascript
> > code do not yield to XHTML validation error');
> > }
> > ]]>
> >
> > Or did you have a special reason to include those slashes?
> >
> > Eelco
> >
> > On 4/18/06, nato <[EMAIL PROTECTED]> wrote:
> > > May I suggest that you inlude <![CDATA[ ... ]]> inside the <script>
> > > element.
> > > For example,
> > > <script type="text/javascript">
> > > //<![CDATA[
> > > function isXhtmlFriendly() {
> > > alert('Yes, I am XHTML friendly');
> > > alert('quotes ", less than <, and ampersand & used in this javascript
> > > code do not yield to XHTML validation error');
> > > }
> > > //]]>
> > > </script>
> > >
> > > The opening and closing CDATA inside the <script> tag do not affect the
> > > javascript code because it is javascript-commented.
> > >
> > > It is a w3c recommendation that we enclose the javascript code inside
> > > CDATA
> > > if the document type is xhtml. Please see
> > > http://www.w3.org/TR/xhtml1/#h-4.8
> > >
> > > I really need to make all my html pages to be valid XHTML because my moron
> > > boss requires it. It will be an advance christmas gift for me if this
> > > issue
> > > be fixed in Wicket-1.2final. Thanks to all.
> > >
> > >
> > >
> > >
> > > On 4/17/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> > > >
> > > > we should add it everywhere:
> > > >
> > > > http://www.w3schools.com/tags/tag_script.asp
> > > >
> > > > it is a required tag.
> > > > And language is depricated and shouldn't be used.
> > > >
> > > >
> > > > johan
> > > >
> > > >
> > > >
> > > >
> > > > On 4/17/06, Juergen Donnerstag < [EMAIL PROTECTED]> wrote:
> > > > > Searching through the code there are quite some locations where we
> > > > > just do <script>
> > > > >
> > > > > Juergen
> > > > >
> > > > > On 4/17/06, Mark Derricutt < [EMAIL PROTECTED]> wrote:
> > > > > > language="text/javascript"???? I hope thats just a
> > > major typo from
> > > > > > type="text/javascript" ?
> > > > > >
> > > > > >
> > > > > > On 4/17/06, Johan Compagner < [EMAIL PROTECTED] > wrote:
> > > > > > >
> > > > > > > that can't be done.
> > > > > > > Because if i do this:
> > > > > > >
> > > > > > > <script language="
> > > > > > > text/javascript">
> > > > > > > var pagemapcookie =
> > > getWicketCookie('pagemap-null');
> > > > > > > if(!pagemapcookie && pagemapcookie !=
> > > > > > '1'){setWicketCookie('pagemap-null',1);}
> > > > > > > else {
> > > > > > > document.location.href
> > > > > > > =
> > > > > >
> > > '/wicket/niceurl/the/homepage/path/wicket:pageMapName/wicket-0';}
> > > > > > > </script>
> > > > > > > then the script is not executed. That can only be used for
> > > including a
> > > > > > script file.
> > > > > > >
> > > > > > >
> > > > > > > johan
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > -------------------------------------------------------
> > > > > This SF.Net email is sponsored by xPML, a groundbreaking scripting
> > > language
> > > > > that extends applications into web and mobile media. Attend the live
> > > webcast
> > > > > and join the prime developer group breaking into this new coding
> > > territory!
> > > > >
> > > http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642
> > > > > _______________________________________________
> > > > > Wicket-user mailing list
> > > > > [email protected]
> > > > >
> > > https://lists.sourceforge.net/lists/listinfo/wicket-user
> > > > >
> > > >
> > > >
> > >
> > >
> >
>
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user
