* Johan Compagner:
> abrupt abort of the sentence?
>
> What does that patch break? Our stable bookmarkable urls?
See attached unit tests output. I kept only the relevant parts.
Basically « : » is converted to « %3A », and catching up would
require a search and replace in the unit tests.
But we can also keep the old behaviour if you wish, encoding the
bookmarkable URLs is not necessary for passing String array in
PageParameters.
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Running wicket.markup.html.link.BookmarkableHomePageLinksTest
=== wicket.markup.html.link.BookmarkableHomePageLinksPage ===
17c17
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=testpagemap:wicket.markup.html.link.BookmarkableHomePageLinksPage"
wicket:id="defaulthompagewithpagemap"></a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=testpagemap%3Awicket.markup.html.link.BookmarkableHomePageLinksPage"
> wicket:id="defaulthompagewithpagemap"></a>
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.097 sec <<<
FAILURE!
Running wicket.markup.html.basic.SimplePageTest
=== wicket.markup.html.basic.SimplePage ===
=== wicket.markup.html.basic.SimplePage_3 ===
=== wicket.markup.html.basic.SimplePage_4 ===
=== wicket.markup.html.basic.SimplePage_5 ===
=== wicket.markup.html.basic.SimplePage_6 ===
=== wicket.markup.html.basic.SimplePage_7 ===
=== wicket.markup.html.basic.SimplePage_8 ===
=== wicket.markup.html.basic.SimplePage_9 ===
=== wicket.markup.html.basic.SimplePage_10 ===
=== wicket.markup.html.basic.SimplePage_11 ===
=== wicket.markup.html.basic.SimplePage_12 ===
10c10
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.basic.SimplePage_3">Link</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.basic.SimplePage_3">Link</a>
13c13
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.basic.SimplePage_3">Link</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.basic.SimplePage_3">Link</a>
16c16
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.basic.SimplePage_3">Link</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.basic.SimplePage_3">Link</a>
19c19
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.basic.SimplePage_3">Link</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.basic.SimplePage_3">Link</a>
22c22
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.basic.SimplePage_3"
wicket:id="link">Link</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.basic.SimplePage_3"
> wicket:id="link">Link</a>
=== wicket.markup.html.basic.SimplePage ===
Tests run: 14, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.528 sec <<<
FAILURE!
Running wicket.markup.html.autolink.AutolinkTest
=== wicket.markup.html.autolink.MyPage ===
6,7c6,7
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.autolink.PageA">Page
A</a>
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.autolink.sub.PageB">Page
B</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.autolink.PageA">Page
> A</a>
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.autolink.sub.PageB">Page
> B</a>
12c12
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.autolink.PageA">Page
A</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.autolink.PageA">Page
> A</a>
=== wicket.markup.html.autolink.PageA ===
5c5
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.autolink.MyPage">My
Page</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.autolink.MyPage">My
> Page</a>
7c7
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.autolink.sub.PageB">Page
B</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.autolink.sub.PageB">Page
> B</a>
=== wicket.markup.html.autolink.sub.PageB ===
Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.19 sec <<<
FAILURE!
Running wicket.markup.html.header.testing3.HeaderTest
=== wicket.markup.html.header.testing3.TestPage ===
=== wicket.markup.html.header.testing3.TestPage : link ===
6c6
< <body>
---
> <body onload="function_1()">
8,9c8,9
< Panel 2
< </wicket:panel></span>
---
> Panel 1
> </wicket:panel></span>
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.048 sec <<<
FAILURE!
Running wicket.markup.html.link.AutolinkTest
=== wicket.markup.html.link.AutolinkPage_1 ===
6c6
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1">Home</a>
8c8
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1">Home</a>
14c14
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1"><span
wicket:id="myLabel">Home</span></a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1"><span
> wicket:id="myLabel">Home</span></a>
19c19
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1&name=test&id=123">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1&name=test&id=123">Home</a>
26c26
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.subdir.Page1">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.subdir.Page1">Home</a>
32c32
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1">Home</a>
=== wicket.markup.html.link.AutolinkPage_2 ===
6,7c6,7
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1">Home</a>
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1">Home</a>
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1">Home</a>
9c9
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1"><span>Home</span></a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1"><span>Home</span></a>
12c12
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1&name=test&id=123">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1&name=test&id=123">Home</a>
16c16
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.subdir.Page1">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.subdir.Page1">Home</a>
19c19
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1">Home</a>
=== wicket.markup.html.link.AutolinkPage_3 ===
4c4
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.XmlPage">Home</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.XmlPage">Home</a>
=== wicket.markup.html.link.AutolinkPage_4 ===
11c11
< <a
href="/WicketTester/WicketTester?wicket:bookmarkablePage=:wicket.markup.html.link.Page1#link1">Link
1</a>
---
> <a
> href="/WicketTester/WicketTester?wicket:bookmarkablePage=%3Awicket.markup.html.link.Page1#link1">Link
> 1</a>
Tests run: 4, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 0.168 sec <<<
FAILURE!
Results :
Tests run: 430, Failures: 9, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] There are test failures.
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20 seconds
[INFO] Finished at: Sun Aug 20 13:13:46 CEST 2006
[INFO] Final Memory: 5M/10M
[INFO] ------------------------------------------------------------------------
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
