if you are going to use this to sell shades to noobs i would change a few things that would scare them away:
instead of ORMDictionary dict = ShadesORMDictionary.getInstance(); i would make it a spring bean and get it through the context - the whole point of spring is to get rid of static injection.
same for orm property of the dao
same for dbsession if its really meant to be used that way - as a singleton
need some connection support code to implement single-connection-per-request. it sucks that every dao op pulls a connection from the datasource imho - cant have transactions that span multiple calls to dao?
need to get rid of all the try/catch/finally - that code looks scarry and is replicated in every method
another thing that would be great to see is how associations are handled - phonebook is not really meant to demo the persistence framework, more the integration thereof with wicket.
oh, and when i load it up and hit the list page i see the query to select all the contacts followed by a select-by-id query for each contact, why is that? bug?
nice job,
-igor
On 10/25/06, Geoff hendrey <[EMAIL PROTECTED]> wrote:Hey Guys,
I was wondering if you had a chance to checkout the integration of Shades with the Phonebook. Is there any way I can make shades more tightly integrated with Wicket?
Does Wicket need a default persistence mechanism?
-geoff
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
