On 2/15/07, Carfield Yim <[EMAIL PROTECTED]> wrote: > On 2/16/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > you shouldnt be calling setresponsepage inside constructors
I think I fixed this for 1.3 and 2.0. Could you please test this and let us know whether that worked for you? It *should* work, but I'm about to take off and don't have time to test this particular instance. > Other than setresponsepage(), there are also methods like > getMarkupId() , which are not work properly in constructor. May be we > can add flag for those object ( or all component ?) to indicate if the > object is inited or not, then throws exception and recommend user to > use alternative? e.g.: That's an idea, though I hopefully just fixed the first issue so that now you can call setResponsePage at any time the RequestCycle is available, and I cannot think of a good end-user reason why this couldn't be called. The getMarkupId method can in fact be called in the constructor in Wicket 2.0; enabling that was one of the key reasons for doing the constructor change. For Wicket 1.3 I guess we could add a flag, though it would mean a tiny little extra bit of state, and I'm not sure it's going to help that many cases. Maybe clear documentation could be sufficient? Eelco ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
