OK. this should be mergeable now.

There is one thing I was wondering though: why is m_result_buffer in 
productionsite.cc of type char[213] rather than std::string? I don't understand 
the relevance of the type for the map_io object, which has a buffer length 
check in it.

I'd prefer a dynamic length type if possible, because we never know how long it 
can get when the strings are translated. Same for char m_statistics_buffer[128];

If these can be changed to string, I could do it in this branch before we merge.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1348795/+merge/228430
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1348795.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to