Review: Approve testing,compile,code-review Code lgtm. That was a lot of work, thanks for doing this!
I tested it and have a few comments: - The team UI is rather clever - maybe too clever, we'll see what the users say. - I found one issue: If I change myself to be dual-control with another player, I can change their team and tribe (expected). If I now change away again from dual-control, I can still change their team and tribe in my UI (but others are not updated, so I think only the button needs to be disabled) Please see the other code reviews for the base branches for some more comments. Great feature! Thanks. -- https://code.launchpad.net/~widelands-dev/widelands/multiplayer_dropdowns/+merge/326302 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/multiplayer_dropdowns_2_init_team. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
