It's part of "RTL support isn't that great yet". The font handler can't handle 
if the font size changes within the same line and the hotspot_y gets messed up.

Thanks for the review - I'll fix the point that you mentioned.

Diff comments:

> 
> === modified file 'src/logic/map_objects/tribes/tribes.cc'
> --- src/logic/map_objects/tribes/tribes.cc    2018-04-07 16:59:00 +0000
> +++ src/logic/map_objects/tribes/tribes.cc    2018-04-30 08:00:23 +0000
> @@ -68,8 +68,9 @@
>  
>  void Tribes::add_trainingsite_type(const LuaTable& table, const 
> EditorGameBase& egbase) {
>       i18n::Textdomain td("tribes");
> +     const std::string msgctxt = table.get_string("msgctxt");
>       buildings_->add(new TrainingSiteDescr(
> -        pgettext_expr(table.get_string("msgctxt").c_str(), 
> table.get_string("descname").c_str()),
> +        pgettext_expr(msgctxt.c_str(), 
> table.get_string("descname").c_str()), msgctxt,

This change is not necessary and left over from when I was playing with 
something. I'll get rid of it.

>          table, egbase));
>  }
>  


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1767919-trainingsite-messages/+merge/344813
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1767919-trainingsite-messages.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to